meta: add legal boilerplate to PR template#3089
Conversation
Added legal boilerplate to clarify contribution rights b/c CLI is FSL
dingsdax
added
the
skip-changelog
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Nice! I just wonder whether we should have some CI check to ensure that this message is intact for non-employees and reject the PR otherwise. Could be helpful on other repos as well.
This would be a separate PR though
szokeasaurusrex
changed the title
|
I don't think this is necessary. Upon opening a PR an external contributor reads this language, there needs to be a conscious action to remove it. I don't think we have such a check for our other FSL licensed repos either. |
|
it is possible that they miss the template if they are opening the PR from |
|
still edge case territory for me. afaik GH CLI respect PR templates unless you override with "gh pr create --body", but that might be a nice addition to our Dangerfile … fine lets create a backlog issue |
2 participants
Added legal boilerplate to clarify contribution rights b/c CLI is FSL